Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2897653002: Add the ability to whitelist plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 5 chunks +37 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-19 14:32:09 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-19 15:38:40 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-19 15:48:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1a7070770ca18778367c1565ff22def3ed9fa05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698