third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h - Issue 2897603003: Get and return String by const-ref if used as rvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/XMLHttpRequestOrString.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h b/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h

index 6781c24a79d71a60ff96d66b827be4a4575518f4..5bf90f37d681fbd517da6c50ef0cc34942981244 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h

@@ -33,9 +33,9 @@ class MODULES_EXPORT BooleanOrString final {

static BooleanOrString fromBoolean(bool);

bool isString() const { return m_type == SpecificTypeString; }

- String getAsString() const;

- void setString(String);

- static BooleanOrString fromString(String);

+ const String& getAsString() const;

+ void setString(const String&);

+ static BooleanOrString fromString(const String&);

BooleanOrString(const BooleanOrString&);

~BooleanOrString();