Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2401)

Unified Diff: chrome/installer/setup/update_active_setup_version_work_item.h

Issue 2897593003: Generalize Active Setup triggering. (Closed)
Patch Set: test fixins Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/update_active_setup_version_work_item.h
diff --git a/chrome/installer/setup/update_active_setup_version_work_item.h b/chrome/installer/setup/update_active_setup_version_work_item.h
index 2a7fb525f886aa49a379631fb3fd5211c5220d8f..76ba867afdd70de2be06af8826f4bc3a4f855fc1 100644
--- a/chrome/installer/setup/update_active_setup_version_work_item.h
+++ b/chrome/installer/setup/update_active_setup_version_work_item.h
@@ -11,8 +11,8 @@
#include "chrome/installer/util/work_item.h"
// A WorkItem that updates (or installs if not present) the Active Setup
-// "Version" field in the registry. Optionally bumping the OS_UPGRADES component
-// on demand. This WorkItem is only viable on machine-wide installs.
+// "Version" field in the registry. Optionally bumping the SELECTIVE_TRIGGER
+// component on demand. This WorkItem is only viable on machine-wide installs.
class UpdateActiveSetupVersionWorkItem : public WorkItem {
public:
// The components of the Active Setup Version entry, in order.
@@ -21,8 +21,9 @@ class UpdateActiveSetupVersionWorkItem : public WorkItem {
MAJOR,
// Unused component, always 0 for now.
UNUSED1,
- // Number of OS upgrades handled since original install.
- OS_UPGRADES,
+ // A component used to selectively trigger Active Setup based on local
+ // factors such as an OS upgrade.
+ SELECTIVE_TRIGGER,
// Unused component, always 0 for now.
UNUSED2,
};
@@ -32,9 +33,9 @@ class UpdateActiveSetupVersionWorkItem : public WorkItem {
// Update (or install if not present) the Active Setup "Version" in the
// registry.
UPDATE,
- // Also bump the OS_UPGRADES component on top of updating the version
+ // Also bump the SELECTIVE_TRIGGER component on top of updating the version
// (will default to 1 if the version was absent or invalid).
- UPDATE_AND_BUMP_OS_UPGRADES_COMPONENT,
+ UPDATE_AND_BUMP_SELECTIVE_TRIGGER,
};
// Constructs an UpdateActiveSetupVersionWorkItem that will perform

Powered by Google App Engine
This is Rietveld 408576698