components/sync/protocol/user_event_specifics.proto - Issue 2897563002: Implement client side logging for language detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/protocol/user_event_specifics.proto

Issue 2897563002: Implement client side logging for language detection. (Closed)

Patch Set: updates Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/protocol/user_event_specifics.proto

diff --git a/components/sync/protocol/user_event_specifics.proto b/components/sync/protocol/user_event_specifics.proto

index d02b2833eb7ca9db5b8859bb587a5b799e961b5b..d36d7642c80aa0d8678d95212ac2409f46c3ad59 100644

--- a/components/sync/protocol/user_event_specifics.proto

+++ b/components/sync/protocol/user_event_specifics.proto

@@ -34,9 +34,9 @@ message LanguageDetection {

// we're not confident about, we may log up to 3 top languages in descending

// order.

repeated Language detected_languages = 1;

- // Adopted language is the final determined language.

+ // Adopted language code is the code of final determined language.

// It will be stored only if it's different from the first detected language.

- optional string adopted_language = 2;

+ optional string adopted_language_code = 2;

}

message UserEventSpecifics {