Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3236)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java

Issue 2897293002: Adding CrHome-specific implementation for home page tile. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
index 9c981b232b4b57cc4f978483d64bf3f2510ba5bb..57972ee42e859276060a0df0cc807e715f38fe06 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
@@ -41,6 +41,29 @@ interface MostVisitedSites {
}
/**
+ * An interface to provide {@link MostVisitedSites} with platform-specific home page data.
+ */
+ interface Client {
dgn 2017/05/25 10:33:33 nit: why not HomePageClient like in c++ ?
fhorschig 2017/05/30 10:25:21 Done.
+ /**
+ * @return Returns whether a home page is active and set.
dgn 2017/05/25 10:33:32 Don't add "Returns" at the beginning of a @return
fhorschig 2017/05/30 10:25:21 Thanks! (3x Done.)
+ */
+ @CalledByNative("Client")
+ boolean isHomePageEnabled();
+
+ /**
+ * @return Returns whether the new tab page was set as home page.
+ */
+ @CalledByNative("Client")
+ boolean isNewTabPageUsedAsHomePage();
+
+ /**
+ * @return Returns the raw URL of the currently set home page.
+ */
+ @CalledByNative("Client")
+ String getHomePageUrl();
+ }
+
+ /**
* This instance must not be used after calling destroy().
*/
void destroy();

Powered by Google App Engine
This is Rietveld 408576698