Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2897273002: Add FunctionEntity.asyncMarker and refactor SourceInformationStrategy to avoid ResolvedAst (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 3106ddbed9e6c901cae54c06492df0ec5356497d..a108061fcc54fe41a97e20e29269e51b084b6f11 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -30,14 +30,9 @@ import '../enqueue.dart'
ResolutionEnqueuer,
TreeShakingEnqueuerStrategy;
import '../frontend_strategy.dart';
-import '../io/multi_information.dart' show MultiSourceInformationStrategy;
-import '../io/position_information.dart' show PositionSourceInformationStrategy;
import '../io/source_information.dart' show SourceInformationStrategy;
-import '../io/start_end_information.dart'
- show StartEndSourceInformationStrategy;
import '../js/js.dart' as jsAst;
import '../js/js.dart' show js;
-import '../js/js_source_mapping.dart' show JavaScriptSourceInformationStrategy;
import '../js/rewrite_async.dart';
import '../js_emitter/js_emitter.dart' show CodeEmitterTask;
import '../kernel/task.dart';
@@ -454,30 +449,6 @@ class JavaScriptBackend {
Tracer tracer;
- static SourceInformationStrategy createSourceInformationStrategy(
- {bool generateSourceMap: false,
- bool useMultiSourceInfo: false,
- bool useNewSourceInfo: false}) {
- if (!generateSourceMap) return const JavaScriptSourceInformationStrategy();
- if (useMultiSourceInfo) {
- if (useNewSourceInfo) {
- return const MultiSourceInformationStrategy(const [
- const PositionSourceInformationStrategy(),
- const StartEndSourceInformationStrategy()
- ]);
- } else {
- return const MultiSourceInformationStrategy(const [
- const StartEndSourceInformationStrategy(),
- const PositionSourceInformationStrategy()
- ]);
- }
- } else if (useNewSourceInfo) {
- return const PositionSourceInformationStrategy();
- } else {
- return const StartEndSourceInformationStrategy();
- }
- }
-
JavaScriptBackend(this.compiler,
{bool generateSourceMap: true,
bool useStartupEmitter: false,
@@ -488,10 +459,8 @@ class JavaScriptBackend {
compiler.elementEnvironment, compiler.frontEndStrategy.dartTypes),
optimizerHints = new OptimizerHintsForTests(
compiler.elementEnvironment, compiler.commonElements),
- this.sourceInformationStrategy = createSourceInformationStrategy(
- generateSourceMap: generateSourceMap,
- useMultiSourceInfo: useMultiSourceInfo,
- useNewSourceInfo: useNewSourceInfo),
+ this.sourceInformationStrategy =
+ compiler.backendStrategy.sourceInformationStrategy,
constantCompilerTask = new JavaScriptConstantTask(compiler),
_nativeDataResolver = new NativeDataResolverImpl(compiler),
_rtiNeedBuilder =
« no previous file with comments | « pkg/compiler/lib/src/io/start_end_information.dart ('k') | pkg/compiler/lib/src/js_backend/element_strategy.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698