Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: pkg/compiler/lib/src/io/position_information.dart

Issue 2897273002: Add FunctionEntity.asyncMarker and refactor SourceInformationStrategy to avoid ResolvedAst (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/io/multi_information.dart ('k') | pkg/compiler/lib/src/io/source_information.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/io/position_information.dart
diff --git a/pkg/compiler/lib/src/io/position_information.dart b/pkg/compiler/lib/src/io/position_information.dart
index 0c94faa51f68dd0cb6447d8b03a84e63282ed5cb..3d10dba8e9b51275d6d6cfd494ec0420e5bf6526 100644
--- a/pkg/compiler/lib/src/io/position_information.dart
+++ b/pkg/compiler/lib/src/io/position_information.dart
@@ -9,7 +9,7 @@ library dart2js.source_information.position;
import '../common.dart';
import '../elements/elements.dart'
- show AstElement, ResolvedAst, ResolvedAstKind;
+ show AstElement, MemberElement, ResolvedAst, ResolvedAstKind;
import '../js/js.dart' as js;
import '../js/js_debug.dart';
import '../js/js_source_mapping.dart';
@@ -101,8 +101,8 @@ class PositionSourceInformationStrategy
const PositionSourceInformationStrategy();
@override
- SourceInformationBuilder createBuilderForContext(ResolvedAst resolvedAst) {
- return new PositionSourceInformationBuilder(resolvedAst);
+ SourceInformationBuilder createBuilderForContext(MemberElement member) {
+ return new PositionSourceInformationBuilder(member);
}
@override
@@ -144,12 +144,13 @@ class PositionSourceInformationBuilder implements SourceInformationBuilder {
final String name;
final ResolvedAst resolvedAst;
- PositionSourceInformationBuilder(ResolvedAst resolvedAst)
- : this.resolvedAst = resolvedAst,
- sourceFile = computeSourceFile(resolvedAst),
- name = computeElementNameForSourceMaps(resolvedAst.element);
+ PositionSourceInformationBuilder(MemberElement member)
+ : this.resolvedAst = member.resolvedAst,
+ sourceFile = computeSourceFile(member.resolvedAst),
+ name = computeElementNameForSourceMaps(member.resolvedAst.element);
- SourceInformation buildDeclaration(ResolvedAst resolvedAst) {
+ SourceInformation buildDeclaration(MemberElement member) {
+ ResolvedAst resolvedAst = member.resolvedAst;
if (resolvedAst.kind != ResolvedAstKind.PARSED) {
SourceSpan span = resolvedAst.element.sourcePosition;
return new PositionSourceInformation(
@@ -250,8 +251,8 @@ class PositionSourceInformationBuilder implements SourceInformationBuilder {
}
@override
- SourceInformationBuilder forContext(ResolvedAst resolvedAst) {
- return new PositionSourceInformationBuilder(resolvedAst);
+ SourceInformationBuilder forContext(MemberElement member) {
+ return new PositionSourceInformationBuilder(member);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/io/multi_information.dart ('k') | pkg/compiler/lib/src/io/source_information.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698