Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2897273002: Add FunctionEntity.asyncMarker and refactor SourceInformationStrategy to avoid ResolvedAst (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add FunctionEntity.asyncMarker and refactor SourceInformationStrategy to avoid ResolvedAst With this change the empty program now runs until codegen onQueueEmpty. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/43efd5039b7c1bf826319369295b872e798d1efe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -153 lines) Patch
M pkg/compiler/lib/src/backend_strategy.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +0 lines, -55 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 2 chunks +58 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/multi_information.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 4 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 4 chunks +12 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +2 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 3 chunks +37 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +22 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 5 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 7 chunks +11 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-24 14:31:13 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-24 17:32:02 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-05-29 08:37:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
43efd5039b7c1bf826319369295b872e798d1efe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698