Fix Omnibox.CharTypedToRepaintLatency regression with D3DVsync experiment

cc/scheduler/begin_frame_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 #define CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 257 matching lines @@
   void RemoveObserver(BeginFrameObserver* obs) override;
   void DidFinishFrame(BeginFrameObserver* obs,
                       const BeginFrameAck& ack) override;
   bool IsThrottled() const override;
   void AsValueInto(base::trace_event::TracedValue* state) const override;
 
   void OnSetBeginFrameSourcePaused(bool paused);
   void OnBeginFrame(const BeginFrameArgs& args);
 
  protected:
+  // Called on AddObserver and gets missed BeginFrameArgs for the given
+  // observer; returns true if the output |args| argument is valid and
+  // OnBeginFrame should be called.
+  virtual bool GetMissedBeginFrameArgs(BeginFrameObserver* obs,

[sunnyps, 2017/05/30 22:13:17]

nit: Can you make this return BeginFrameArgs? The BFS can look at
BeginFrameArgs::IsValid and decide if needs to be forwarded to the observer as a
missed frame.

[stanisc, 2017/05/31 01:17:52]

Returning BeginFrameArgs would be slightly less optimal because that would
require an extra struct copy in some cases. But that probably doesn't matter
much considering that this is called infrequently. Done.

+                                       BeginFrameArgs* missed_args);
+
   BeginFrameArgs last_begin_frame_args_;

[sunnyps, 2017/05/30 22:13:17]

nit: Can you add a method to get last_begin_frame_args_ instead of accessing it
directly in the subclass?

[stanisc, 2017/05/31 01:17:52]

I am reluctant to do this because this member is already protected which means
it is intended to be accessed directly in derived classes. And the pattern so
far has been to access these protected members directly from derived classes.

   std::unordered_set<BeginFrameObserver*> observers_;
   ExternalBeginFrameSourceClient* client_;
   bool paused_ = false;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ExternalBeginFrameSource);
 };
 
 }  // namespace cc
 
 #endif  // CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_