chrome/browser/permissions/permission_request_impl.h - Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_impl.h

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_request_impl.h

diff --git a/chrome/browser/permissions/permission_request_impl.h b/chrome/browser/permissions/permission_request_impl.h

index 035a5b6f5559b101b487df6345afb8ccdf72368d..28f8a4f8109da04ab3216d54e25f607e99650024 100644

--- a/chrome/browser/permissions/permission_request_impl.h

+++ b/chrome/browser/permissions/permission_request_impl.h

@@ -38,6 +38,9 @@ class PermissionRequestImpl : public PermissionRequest {

private:

// PermissionRequest:

IconId GetIconId() const override;

+#if defined(OS_ANDROID)

+ base::string16 GetMessageText() const override;

+#endif

base::string16 GetMessageTextFragment() const override;

GURL GetOrigin() const override;

// Remember to call RegisterActionTaken for these methods if you are