Chromium Code Reviews| Index: services/service_manager/public/cpp/test/BUILD.gn |
| diff --git a/services/service_manager/public/cpp/test/BUILD.gn b/services/service_manager/public/cpp/test/BUILD.gn |
| index 90f3aea1ce0b10f02d095e093cbc46fc8c5631d6..981bf1f1baf2b1fc35eef9b8a67d05b24a761f38 100644 |
| --- a/services/service_manager/public/cpp/test/BUILD.gn |
| +++ b/services/service_manager/public/cpp/test/BUILD.gn |
| @@ -4,13 +4,14 @@ |
| import("//testing/test.gni") |
| -# NOTE: Don't depend on this target directly. Instead use the service_test |
| -# template from //services/service_manager/public/tools/test/service_test.gni. |
| -source_set("run_all_service_tests") { |
| +# Only depend on this target if you're trying to implement a custom service |
| +# test runner. |
| +source_set("common_initialization") { |
| testonly = true |
| sources = [ |
| - "run_all_service_tests.cc", |
| + "common_initialization.cc", |
| + "common_initialization.h", |
| "service_test_catalog.h", |
| ] |
| @@ -27,3 +28,19 @@ source_set("run_all_service_tests") { |
| deps += [ "//mojo/android:libsystem_java" ] |
| } |
| } |
| + |
| +# NOTE: Don't depend on this target directly. Instead use the service_test |
|
sky
2017/05/24 22:34:11
Is it possible to enforce this with visibility?
Elliot Glaysher
2017/05/24 22:42:09
I don't believe it can. The visibility check happe
|
| +# template from //services/service_manager/public/tools/test/service_test.gni. |
| +source_set("run_all_service_tests") { |
| + testonly = true |
| + |
| + sources = [ |
| + "run_all_service_tests.cc", |
| + ] |
| + |
| + deps = [ |
| + ":common_initialization", |
| + "//base", |
| + "//base/test:test_support", |
| + ] |
| +} |