Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: BUILD.gn

Issue 2897123002: [Fuchsia] Fix test image creation (Closed)
Patch Set: Fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index e12a15e5fc6edf25b8fc1614593c33ae4a04256c..d090a986939f91b34deb52e6853161a36f25a095 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -118,9 +118,8 @@ group("samples") {
]
}
-# The rules below build a qemu Fuchsia OS image that includes the Dart tree
-# under /system/test/dart. Building this image is gated by the GN argument
-# 'dart_build_fuchsia_test_image' because building the image is slow.
+# The rules below build a Fuchsia OS image that includes the Dart tree
+# under /system/test/dart.
if (is_fuchsia) {
declare_args() {
dart_build_fuchsia_test_image = false
@@ -144,14 +143,14 @@ if (is_fuchsia) {
}
mkbootfs_gen = get_label_info("//packages/gn:mkbootfs", "target_gen_dir")
- user_manifest = "$mkbootfs_gen/user.bootfs.manifest"
+ system_manifest = "$mkbootfs_gen/system.bootfs.manifest"
script = "tools/gen_fuchsia_test_manifest.py"
args = [
"-m",
mode,
"-u",
- rebase_path(user_manifest),
+ rebase_path(system_manifest),
"-o",
rebase_path(output_prefix),
]
@@ -166,6 +165,9 @@ if (is_fuchsia) {
"runtime/bin:run_vm_tests",
]
+ mkbootfs_gen = get_label_info("//packages/gn:mkbootfs", "target_gen_dir")
+ boot_manifest = "$mkbootfs_gen/boot.bootfs.manifest"
+
# Compute path to magenta bootdata.bin
if (current_cpu == "arm64") {
magenta_bootdata =
@@ -190,7 +192,9 @@ if (is_fuchsia) {
script = "//packages/gn/make_bootfs.py"
args = [
- "--manifest",
+ "--boot-manifest",
+ rebase_path(boot_manifest),
+ "--system-manifest",
rebase_path(input),
"--output-file",
rebase_path(output),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698