Issue 2897093002: Revert "dart2js: replace 'invariant' with 'failedAt' to defer interpolation"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2897093002: Revert "dart2js: replace 'invariant' with 'failedAt' to defer interpolation" (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js: replace 'invariant' with 'failedAt' to defer interpolation" Investigating some analyzer warnings. TBR=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3e72e09a9707ed54050bf0f5724547c18bac9965

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -138 lines)			Patch
	M	pkg/compiler/lib/src/diagnostics/invariant.dart	View		2 chunks	+1 line, -25 lines	0 comments	Download
	M	pkg/compiler/lib/src/elements/modelx.dart	View		25 chunks	+92 lines, -113 lines	0 comments	Download

Total messages: 3 (1 generated)

sra1

Committed patchset #1 (id:1) manually as 3e72e09a9707ed54050bf0f5724547c18bac9965 (presubmit successful).

3 years, 7 months ago (2017-05-23 17:48:53 UTC) #2

Message was sent while issue was closed.

lgtm