Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.h

Issue 2897063002: Network service: Implement URLLoader chaining for interceptors (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_controllee_request_handler.h
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.h b/content/browser/service_worker/service_worker_controllee_request_handler.h
index 329edcfd3fa3eed1822abd2e9a7de6112e2671ad..df45509de6c4211c821f288e4849adef2597429d 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.h
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.h
@@ -53,11 +53,25 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler
~ServiceWorkerControlleeRequestHandler() override;
// Called via custom URLRequestJobFactory.
+ // Returning a nullptr indicates that the request is not handled by
+ // this handler.
+ // This could get called multiple times during the lifetime.
net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate,
ResourceContext* resource_context) override;
+ // Used only for PlzNavigate and --enable-network-service cases.
michaeln 2017/05/26 01:28:31 Maybe comment that this method replaces MaybeCreat
kinuko 2017/05/26 14:30:05 Done.
+ // This could get called multiple times during the lifetime in redirect
+ // cases. (In fallback-to-network cases we basically forward the request
+ // to the request to the next request handler)
+ // URLLoaderRequestHandler overrides:
+ void Start(const ResourceRequest& resource_request,
+ URLLoaderRequestHandler::Controller* controller,
+ ResourceContext* resource_context,
+ mojom::URLLoaderAssociatedRequest loader_request,
+ mojom::URLLoaderClientPtr loader_client_ptr) override;
+
private:
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,
ActivateWaitingVersion);

Powered by Google App Engine
This is Rietveld 408576698