Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)
Patch Set: sync for PrimaryBFS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
index ec62e2bf8004b74b26233bcf62acb894eb77e5a3..601a40a4d9a7792daa29a2a808b92f9b8722c95e 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
@@ -244,49 +244,8 @@ TEST_F(RenderWidgetHostViewChildFrameTest, FrameEviction) {
EXPECT_TRUE(view_->has_frame());
}
-// Tests that BeginFrameAcks are forwarded correctly from the
-// SwapCompositorFrame and DidNotProduceFrame IPCs through the
-// CompositorFrameSinkSupport.
-TEST_F(RenderWidgetHostViewChildFrameTest, ForwardsBeginFrameAcks) {
- gfx::Size view_size(100, 100);
- gfx::Rect view_rect(view_size);
- float scale_factor = 1.f;
-
- view_->SetSize(view_size);
- view_->Show();
-
- // Replace BeginFrameSource so that we can observe acknowledgments.
- cc::FakeExternalBeginFrameSource source(0.f, false);
- uint32_t source_id = source.source_id();
- view_->support_->SetBeginFrameSource(&source);
- view_->SetNeedsBeginFrames(true);
-
- {
- cc::BeginFrameArgs args =
- cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, source_id, 5u);
- source.TestOnBeginFrame(args);
-
- // Ack from CompositorFrame is forwarded.
- cc::BeginFrameAck ack(source_id, 5, 4, true);
- cc::CompositorFrame frame =
- CreateDelegatedFrame(scale_factor, view_size, view_rect);
- frame.metadata.begin_frame_ack = ack;
- view_->SubmitCompositorFrame(kArbitraryLocalSurfaceId, std::move(frame));
- EXPECT_EQ(ack, source.LastAckForObserver(view_->support_.get()));
- }
-
- {
- cc::BeginFrameArgs args =
- cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, source_id, 6u);
- source.TestOnBeginFrame(args);
-
- // Explicit ack through OnDidNotProduceFrame is forwarded.
- cc::BeginFrameAck ack(source_id, 6, 4, false);
- view_->OnDidNotProduceFrame(ack);
- EXPECT_EQ(ack, source.LastAckForObserver(view_->support_.get()));
- }
-
- view_->SetNeedsBeginFrames(false);
-}
+// TODO(eseckler): Add back tests for BeginFrameAck forwarding through
+// RenderWidgetHostViewChildFrame and CompositorFrameSinkSupport when we add
+// plumbing of BeginFrameAcks through SurfaceObservers.
} // namespace content
« no previous file with comments | « components/exo/surface_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698