Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: cc/test/fake_external_begin_frame_source.h

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)
Patch Set: sync for PrimaryBFS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_synchronization_unittest.cc ('k') | cc/test/fake_external_begin_frame_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/fake_external_begin_frame_source.h
diff --git a/cc/test/fake_external_begin_frame_source.h b/cc/test/fake_external_begin_frame_source.h
index af0c0a99274e671ce0259a012c5447b9b1719f74..0a03149c571834e14306e895c484417360fba972 100644
--- a/cc/test/fake_external_begin_frame_source.h
+++ b/cc/test/fake_external_begin_frame_source.h
@@ -39,8 +39,7 @@ class FakeExternalBeginFrameSource
// BeginFrameSource implementation.
void AddObserver(BeginFrameObserver* obs) override;
void RemoveObserver(BeginFrameObserver* obs) override;
- void DidFinishFrame(BeginFrameObserver* obs,
- const BeginFrameAck& ack) override;
+ void DidFinishFrame(BeginFrameObserver* obs) override;
bool IsThrottled() const override;
BeginFrameArgs CreateBeginFrameArgs(
@@ -53,10 +52,6 @@ class FakeExternalBeginFrameSource
size_t num_observers() const { return observers_.size(); }
- const BeginFrameAck& LastAckForObserver(BeginFrameObserver* obs) {
- return last_acks_[obs];
- }
-
private:
void PostTestOnBeginFrame();
@@ -68,7 +63,6 @@ class FakeExternalBeginFrameSource
uint64_t next_begin_frame_number_ = BeginFrameArgs::kStartingFrameNumber;
std::set<BeginFrameObserver*> observers_;
base::CancelableCallback<void(const BeginFrameArgs&)> begin_frame_task_;
- std::unordered_map<BeginFrameObserver*, BeginFrameAck> last_acks_;
base::WeakPtrFactory<FakeExternalBeginFrameSource> weak_ptr_factory_;
};
« no previous file with comments | « cc/surfaces/surface_synchronization_unittest.cc ('k') | cc/test/fake_external_begin_frame_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698