Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2957)

Unified Diff: cc/surfaces/display_scheduler.cc

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)
Patch Set: sync for PrimaryBFS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/surfaces/primary_begin_frame_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/display_scheduler.cc
diff --git a/cc/surfaces/display_scheduler.cc b/cc/surfaces/display_scheduler.cc
index 40e80bf97bd36034d435bbe34c3b4242295cccd4..829bf700ab9ff63252bc1f4c82d1de07e9c37415 100644
--- a/cc/surfaces/display_scheduler.cc
+++ b/cc/surfaces/display_scheduler.cc
@@ -364,11 +364,9 @@ void DisplayScheduler::OnBeginFrameDeadline() {
}
void DisplayScheduler::DidFinishFrame(bool did_draw) {
- // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
- BeginFrameAck ack(current_begin_frame_args_.source_id,
- current_begin_frame_args_.sequence_number,
- current_begin_frame_args_.sequence_number, did_draw);
- begin_frame_source_->DidFinishFrame(this, ack);
+ DCHECK(begin_frame_source_);
+ // TODO(eseckler): Let client know that frame was completed.
+ begin_frame_source_->DidFinishFrame(this);
}
void DisplayScheduler::DidSwapBuffers() {
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/surfaces/primary_begin_frame_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698