content/renderer/gpu/compositor_external_begin_frame_source.h - Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/compositor_external_begin_frame_source.h

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)

Patch Set: fix exo compile error Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/compositor_external_begin_frame_source.h

diff --git a/content/renderer/gpu/compositor_external_begin_frame_source.h b/content/renderer/gpu/compositor_external_begin_frame_source.h

index 41eb692ca383cb7ec05a86371361f321a09c072d..96520a0210d9cfa3a1db2ebc42d1219699295f7e 100644

--- a/content/renderer/gpu/compositor_external_begin_frame_source.h

+++ b/content/renderer/gpu/compositor_external_begin_frame_source.h

@@ -43,8 +43,7 @@ class CompositorExternalBeginFrameSource

// cc::BeginFrameSource implementation.

void AddObserver(cc::BeginFrameObserver* obs) override;

void RemoveObserver(cc::BeginFrameObserver* obs) override;

- void DidFinishFrame(cc::BeginFrameObserver* obs,

- const cc::BeginFrameAck& ack) override;

+ void DidFinishFrame(cc::BeginFrameObserver* obs) override;

bool IsThrottled() const override;

// cc::ExternalBeginFrameSourceClient implementation.