Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3832)

Unified Diff: cc/surfaces/display_scheduler.cc

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)
Patch Set: fix exo compile error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/display_scheduler.cc
diff --git a/cc/surfaces/display_scheduler.cc b/cc/surfaces/display_scheduler.cc
index 40e80bf97bd36034d435bbe34c3b4242295cccd4..81483524e092fa6592d1f9b17ed241762878322b 100644
--- a/cc/surfaces/display_scheduler.cc
+++ b/cc/surfaces/display_scheduler.cc
@@ -364,11 +364,8 @@ void DisplayScheduler::OnBeginFrameDeadline() {
}
void DisplayScheduler::DidFinishFrame(bool did_draw) {
- // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
- BeginFrameAck ack(current_begin_frame_args_.source_id,
- current_begin_frame_args_.sequence_number,
- current_begin_frame_args_.sequence_number, did_draw);
- begin_frame_source_->DidFinishFrame(this, ack);
+ // TODO(eseckler): Let client know that frame was completed.
sunnyps 2017/05/24 02:38:26 nit: DCHECK(begin_frame_source_) here
Eric Seckler 2017/05/24 09:00:40 Done.
+ begin_frame_source_->DidFinishFrame(this);
}
void DisplayScheduler::DidSwapBuffers() {

Powered by Google App Engine
This is Rietveld 408576698