Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: cc/scheduler/begin_frame_source.cc

Issue 2897053002: [cc] Remove BeginFrameAck from BFS::DidFinishFrame and update tests. (Closed)
Patch Set: sync for PrimaryBFS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source.h ('k') | cc/scheduler/begin_frame_source_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/scheduler/begin_frame_source.h" 5 #include "cc/scheduler/begin_frame_source.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/atomic_sequence_num.h" 9 #include "base/atomic_sequence_num.h"
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 void BackToBackBeginFrameSource::RemoveObserver(BeginFrameObserver* obs) { 107 void BackToBackBeginFrameSource::RemoveObserver(BeginFrameObserver* obs) {
108 DCHECK(obs); 108 DCHECK(obs);
109 DCHECK(observers_.find(obs) != observers_.end()); 109 DCHECK(observers_.find(obs) != observers_.end());
110 observers_.erase(obs); 110 observers_.erase(obs);
111 pending_begin_frame_observers_.erase(obs); 111 pending_begin_frame_observers_.erase(obs);
112 if (pending_begin_frame_observers_.empty()) 112 if (pending_begin_frame_observers_.empty())
113 time_source_->SetActive(false); 113 time_source_->SetActive(false);
114 } 114 }
115 115
116 void BackToBackBeginFrameSource::DidFinishFrame(BeginFrameObserver* obs, 116 void BackToBackBeginFrameSource::DidFinishFrame(BeginFrameObserver* obs) {
117 const BeginFrameAck& ack) {
118 if (observers_.find(obs) != observers_.end()) { 117 if (observers_.find(obs) != observers_.end()) {
119 pending_begin_frame_observers_.insert(obs); 118 pending_begin_frame_observers_.insert(obs);
120 time_source_->SetActive(true); 119 time_source_->SetActive(true);
121 } 120 }
122 } 121 }
123 122
124 bool BackToBackBeginFrameSource::IsThrottled() const { 123 bool BackToBackBeginFrameSource::IsThrottled() const {
125 return false; 124 return false;
126 } 125 }
127 126
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 DCHECK(obs); 303 DCHECK(obs);
305 DCHECK(observers_.find(obs) != observers_.end()); 304 DCHECK(observers_.find(obs) != observers_.end());
306 305
307 observers_.erase(obs); 306 observers_.erase(obs);
308 if (observers_.empty()) { 307 if (observers_.empty()) {
309 last_begin_frame_args_ = BeginFrameArgs(); 308 last_begin_frame_args_ = BeginFrameArgs();
310 client_->OnNeedsBeginFrames(false); 309 client_->OnNeedsBeginFrames(false);
311 } 310 }
312 } 311 }
313 312
314 void ExternalBeginFrameSource::DidFinishFrame(BeginFrameObserver* obs,
315 const BeginFrameAck& ack) {}
316
317 bool ExternalBeginFrameSource::IsThrottled() const { 313 bool ExternalBeginFrameSource::IsThrottled() const {
318 return true; 314 return true;
319 } 315 }
320 316
321 void ExternalBeginFrameSource::OnSetBeginFrameSourcePaused(bool paused) { 317 void ExternalBeginFrameSource::OnSetBeginFrameSourcePaused(bool paused) {
322 if (paused_ == paused) 318 if (paused_ == paused)
323 return; 319 return;
324 paused_ = paused; 320 paused_ = paused;
325 std::unordered_set<BeginFrameObserver*> observers(observers_); 321 std::unordered_set<BeginFrameObserver*> observers(observers_);
326 for (auto* obs : observers) 322 for (auto* obs : observers)
(...skipping 12 matching lines...) Expand all
339 DCHECK((args.source_id != last_args.source_id) || 335 DCHECK((args.source_id != last_args.source_id) ||
340 (args.sequence_number > last_args.sequence_number)) 336 (args.sequence_number > last_args.sequence_number))
341 << "current " << args.AsValue()->ToString() << ", last " 337 << "current " << args.AsValue()->ToString() << ", last "
342 << last_args.AsValue()->ToString(); 338 << last_args.AsValue()->ToString();
343 obs->OnBeginFrame(args); 339 obs->OnBeginFrame(args);
344 } 340 }
345 } 341 }
346 } 342 }
347 343
348 } // namespace cc 344 } // namespace cc
OLDNEW
« no previous file with comments | « cc/scheduler/begin_frame_source.h ('k') | cc/scheduler/begin_frame_source_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698