Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

Issue 2897033005: DevTools: introduce setting to filter only user messages from console API (Closed)
Patch Set: ac Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
index c6364e9419b3f0a03e843d28f1f6ffe06a28f686..f12d996905cb3f78320648ba0f306d5a6cceefa6 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
@@ -7,7 +7,7 @@ console.log("message from page!");
function test()
{
- var checkbox = Console.ConsoleView.instance()._filter._filterByExecutionContextCheckbox.inputElement;
+ var filterByExecutionContextSetting = Common.moduleSetting('selectedContextFilterEnabled');
pfeldman 2017/05/23 20:56:32 console.selected...
luoe 2017/05/23 21:03:44 Done.
//we can't use usual InspectorTest.dumpConsoleMessages(), because it dumps url of message and it flakes in case of iframe
function dumpVisibleConsoleMessageText()
@@ -22,7 +22,7 @@ function test()
function testInitialState(next)
{
- if (checkbox.checked)
+ if (filterByExecutionContextSetting.get())
InspectorTest.addResult("\"Show target messages\" checkbox should be unchecked by default");
dumpVisibleConsoleMessageText();
next();
@@ -31,7 +31,7 @@ function test()
function testPageOnlyMessages(next)
{
InspectorTest.changeExecutionContext("top");
- checkbox.click();
+ filterByExecutionContextSetting.set(true);
dumpVisibleConsoleMessageText();
next();
},
@@ -45,7 +45,7 @@ function test()
function testAllMessagesWithFrameContext(next)
{
- checkbox.click();
+ filterByExecutionContextSetting.set(false);
dumpVisibleConsoleMessageText();
next();
}

Powered by Google App Engine
This is Rietveld 408576698