ui/android/DEPS - Issue 2896993002: Route OnDragEvent through ViewAndroid tree

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/DEPS

Issue 2896993002: Route OnDragEvent through ViewAndroid tree (Closed)

Patch Set: comment 2 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+cc/layers",	2 "+cc/layers",

3 "+cc/output",	3 "+cc/output",

4 "+cc/resources",	4 "+cc/resources",

5 "+cc/scheduler/begin_frame_source.h",	5 "+cc/scheduler/begin_frame_source.h",

6 "+cc/surfaces",	6 "+cc/surfaces",

7 "+cc/test/stub_layer_tree_host_client.h",	7 "+cc/test/stub_layer_tree_host_client.h",

8 "+cc/test/test_task_graph_runner.h",	8 "+cc/test/test_task_graph_runner.h",

9 "+cc/trees/layer_tree_host.h",	9 "+cc/trees/layer_tree_host.h",

10 "+jni",	10 "+jni",

11 "+skia/ext",	11 "+skia/ext",

12 "+third_party/skia",	12 "+third_party/skia",

13 "+ui/base/layout.h",	13 "+ui/base/layout.h",

14 "+ui/base/resource/resource_bundle.h",	14 "+ui/base/resource/resource_bundle.h",

15 "+ui/base/ui_base_paths.h",	15 "+ui/base/ui_base_paths.h",

	16 "+ui/base/ui_base_switches_util.h",
	sky 2017/05/25 23:57:59 Why not +ui/base? This target depends upon ui/base Why not +ui/base? This target depends upon ui/base, so it seems silly to also have deps like this. Maybe I'm missing why that is? Jinsuk Kim 2017/05/26 00:16:48 Honestly no idea. I was just following what has be Show quoted text On 2017/05/25 23:57:59, sky wrote: > Why not +ui/base? This target depends upon ui/base, so it seems silly to also > have deps like this. Maybe I'm missing why that is? Honestly no idea. I was just following what has been done - adding one header file at a time. Replaced all ui/base/.h with +ui/base. Same for ui/events/.h which this target also depend on.
16 "+ui/display",	17 "+ui/display",

	18 "+ui/events/android/drag_event_android.h",

17 "+ui/events/android/motion_event_android.h",	19 "+ui/events/android/motion_event_android.h",

18 "+ui/events/base_event_utils.h",	20 "+ui/events/base_event_utils.h",

19 "+ui/gfx",	21 "+ui/gfx",

20 ]	22 ]

OLD	NEW

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | ui/android/event_forwarder.h » ('j') | no next file with comments »