Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2896983002: Lookup const constructor invocation like other constants (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Lookup const constructor invocation like other constants We should really be building the constants from kernel ir. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/1a965036b5dad13aeffab7691d5cf515a06e8078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 7 months ago (2017-05-23 02:22:15 UTC) #2
Emily Fortuna
lgtm nice!
3 years, 7 months ago (2017-05-23 17:21:49 UTC) #3
sra1
3 years, 7 months ago (2017-05-23 20:52:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a965036b5dad13aeffab7691d5cf515a06e8078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698