Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 289693002: Removed "disable-first-run-ui" flag and switch. (Closed)

Created:
6 years, 7 months ago by dzhioev (left Google)
Modified:
6 years, 7 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Removed "disable-first-run-ui" flag and switch. BUG=361083 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dzhioev (left Google)
6 years, 7 months ago (2014-05-14 14:36:39 UTC) #1
dzhioev (left Google)
On 2014/05/14 14:36:39, dzhioev wrote: Mike, please review.
6 years, 7 months ago (2014-05-22 14:41:54 UTC) #2
miket_OOO
lgtm
6 years, 7 months ago (2014-05-22 15:33:00 UTC) #3
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-22 16:18:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/289693002/1
6 years, 7 months ago (2014-05-22 16:19:51 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 23:09:57 UTC) #6
Message was sent while issue was closed.
Change committed as 272357

Powered by Google App Engine
This is Rietveld 408576698