Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2896903002: Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as … (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/jit_optimizer.cc
diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc
index d536fd60223a8b8b5a4cc5f375fccb5f35733de2..199f296388a99b2ede9208d814dd3adf477a6fa1 100644
--- a/runtime/vm/jit_optimizer.cc
+++ b/runtime/vm/jit_optimizer.cc
@@ -607,7 +607,7 @@ bool JitOptimizer::TryReplaceWithEqualityOp(InstanceCallInstr* call,
StrictCompareInstr* comp = new (Z)
StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
new (Z) Value(left), new (Z) Value(right),
- false); // No number check.
+ /* number_check = */ false, Thread::kNoDeoptId);
ReplaceCall(call, comp);
return true;
}
@@ -1361,10 +1361,9 @@ void JitOptimizer::ReplaceWithInstanceOf(InstanceCallInstr* call) {
ConstantInstr* cid =
flow_graph()->GetConstant(Smi::Handle(Z, Smi::New(type_cid)));
- StrictCompareInstr* check_cid =
- new (Z) StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
- new (Z) Value(left_cid), new (Z) Value(cid),
- false); // No number check.
+ StrictCompareInstr* check_cid = new (Z) StrictCompareInstr(
+ call->token_pos(), Token::kEQ_STRICT, new (Z) Value(left_cid),
+ new (Z) Value(cid), /* number_check = */ false, Thread::kNoDeoptId);
ReplaceCall(call, check_cid);
return;
}
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698