runtime/vm/flow_graph.cc - Issue 2896903002: Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph.cc

Issue 2896903002: Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as … (Closed)

Patch Set: format Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph.cc

diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc

index 84b9e483e42517457bd48e6b7bce6e65207ac959..abe5e7c6a579b3660e83b36c336a946ea53cebbc 100644

--- a/runtime/vm/flow_graph.cc

+++ b/runtime/vm/flow_graph.cc

@@ -1018,7 +1018,8 @@ void FlowGraph::Rename(GrowableArray<PhiInstr*>* live_phis,

for (intptr_t i = parameter_count(); i < variable_count(); ++i) {

if (i == CurrentContextEnvIndex()) {

if (function().IsClosureFunction()) {

- CurrentContextInstr* context = new CurrentContextInstr();

+ CurrentContextInstr* context =

+ new CurrentContextInstr(Thread::Current()->GetNextDeoptId());

Vyacheslav Egorov (Google) 2017/05/23 12:00:01 kNoDeoptId - it can't deopt anyway.

context->set_ssa_temp_index(alloc_ssa_temp_index()); // New SSA temp.

AddToInitialDefinitions(context);

env.Add(context);