Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as …

runtime/vm/jit_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 #ifndef DART_PRECOMPILED_RUNTIME
 #include "vm/jit_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/branch_optimizer.h"
 #include "vm/cha.h"
 #include "vm/compiler.h"
@@ skipping 586 matching lines @@
                                               smi_or_null)) {
       AddChecksForArgNr(call, left, 0);
       AddChecksForArgNr(call, right, 0);
       cid = kSmiCid;
     } else {
       // Shortcut for equality with null.
       ConstantInstr* right_const = right->AsConstant();
       ConstantInstr* left_const = left->AsConstant();
       if ((right_const != NULL && right_const->value().IsNull()) ||
           (left_const != NULL && left_const->value().IsNull())) {
-        StrictCompareInstr* comp = new (Z)
-            StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
-                               new (Z) Value(left), new (Z) Value(right),
-                               false);  // No number check.
+        StrictCompareInstr* comp = new (Z) StrictCompareInstr(
+            call->token_pos(), Token::kEQ_STRICT, new (Z) Value(left),
+            new (Z) Value(right), false,  // No number check.
+            Thread::Current()->GetNextDeoptId());

[Vyacheslav Egorov (Google), 2017/05/23 12:00:03]

kNoDeoptId (because we are in the optimizer and strict compare can't deopt)

         ReplaceCall(call, comp);
         return true;
       }
       return false;
     }
   }
   ASSERT(cid != kIllegalCid);
   EqualityCompareInstr* comp = new (Z)
       EqualityCompareInstr(call->token_pos(), op_kind, new (Z) Value(left),
                            new (Z) Value(right), cid, call->deopt_id());
@@ skipping 733 matching lines @@
     }
   }
 
   if (TypeCheckAsClassEquality(type)) {
     LoadClassIdInstr* left_cid = new (Z) LoadClassIdInstr(new (Z) Value(left));
     InsertBefore(call, left_cid, NULL, FlowGraph::kValue);
     const intptr_t type_cid = Class::Handle(Z, type.type_class()).id();
     ConstantInstr* cid =
         flow_graph()->GetConstant(Smi::Handle(Z, Smi::New(type_cid)));
 
-    StrictCompareInstr* check_cid =
-        new (Z) StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
-                                   new (Z) Value(left_cid), new (Z) Value(cid),
-                                   false);  // No number check.
+    StrictCompareInstr* check_cid = new (Z) StrictCompareInstr(
+        call->token_pos(), Token::kEQ_STRICT, new (Z) Value(left_cid),
+        new (Z) Value(cid), false,  // No number check.

[Vyacheslav Egorov (Google), 2017/05/23 12:00:03]

maybe better /* number_check = */ false

+        Thread::Current()->GetNextDeoptId());

[Vyacheslav Egorov (Google), 2017/05/23 12:00:03]

ditto

     ReplaceCall(call, check_cid);
     return;
   }
 
   InstanceOfInstr* instance_of = new (Z) InstanceOfInstr(
       call->token_pos(), new (Z) Value(left),
       new (Z) Value(instantiator_type_args), new (Z) Value(function_type_args),
       type, call->deopt_id());
   ReplaceCall(call, instance_of);
 }
@@ skipping 400 matching lines @@
   // Discard the environment from the original instruction because the store
   // can't deoptimize.
   instr->RemoveEnvironment();
   ReplaceCall(instr, store);
   return true;
 }
 
 
 }  // namespace dart
 #endif  // DART_PRECOMPILED_RUNTIME