Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as …

runtime/vm/aot_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/aot_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/branch_optimizer.h"
 #include "vm/cha.h"
 #include "vm/compiler.h"
@@ skipping 697 matching lines @@
 
       cid = kSmiCid;
     } else {
       // Shortcut for equality with null.
       // TODO(vegorov): this optimization is not speculative and should
       // be hoisted out of this function.
       ConstantInstr* right_const = right->AsConstant();
       ConstantInstr* left_const = left->AsConstant();
       if ((right_const != NULL && right_const->value().IsNull()) ||
           (left_const != NULL && left_const->value().IsNull())) {
-        StrictCompareInstr* comp = new (Z)
-            StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
-                               new (Z) Value(left), new (Z) Value(right),
-                               false);  // No number check.
+        StrictCompareInstr* comp = new (Z) StrictCompareInstr(
+            call->token_pos(), Token::kEQ_STRICT, new (Z) Value(left),
+            new (Z) Value(right), false,  // No number check.

[Vyacheslav Egorov (Google), 2017/05/23 12:00:00]

better maybe write this comment /* number_check = */ false

+            Thread::Current()->GetNextDeoptId());

[Vyacheslav Egorov (Google), 2017/05/23 12:00:00]

I think this can be kNoDeoptId

We should probably find a way to stop using deopt_ids altogether in the AOT
compiler as they are not doing anything.

         ReplaceCall(call, comp);
         return true;
       }
       return false;
     }
   }
   ASSERT(cid != kIllegalCid);
   EqualityCompareInstr* comp = new (Z)
       EqualityCompareInstr(call->token_pos(), op_kind, new (Z) Value(left),
                            new (Z) Value(right), cid, call->deopt_id());
@@ skipping 710 matching lines @@
     type = AbstractType::Cast(call->ArgumentAt(3)->AsConstant()->value()).raw();
   }
 
   if (TypeCheckAsClassEquality(type)) {
     LoadClassIdInstr* left_cid = new (Z) LoadClassIdInstr(new (Z) Value(left));
     InsertBefore(call, left_cid, NULL, FlowGraph::kValue);
     const intptr_t type_cid = Class::Handle(Z, type.type_class()).id();
     ConstantInstr* cid =
         flow_graph()->GetConstant(Smi::Handle(Z, Smi::New(type_cid)));
 
-    StrictCompareInstr* check_cid =
-        new (Z) StrictCompareInstr(call->token_pos(), Token::kEQ_STRICT,
-                                   new (Z) Value(left_cid), new (Z) Value(cid),
-                                   false);  // No number check.
+    StrictCompareInstr* check_cid = new (Z) StrictCompareInstr(
+        call->token_pos(), Token::kEQ_STRICT, new (Z) Value(left_cid),
+        new (Z) Value(cid), false,  // No number check.
+        Thread::Current()->GetNextDeoptId());

[Vyacheslav Egorov (Google), 2017/05/23 12:00:00]

Ditto.

     ReplaceCall(call, check_cid);
     return;
   }
 
   if (precompiler_ != NULL) {
     TypeRangeCache* cache = precompiler_->type_range_cache();
     intptr_t lower_limit, upper_limit;
     if (cache != NULL &&
         cache->InstanceOfHasClassRange(type, &lower_limit, &upper_limit)) {
       // left.instanceof(type) =>
@@ skipping 756 matching lines @@
                                   FlowGraph::kEffect);
         current_iterator()->RemoveCurrentFromGraph();
       }
     }
   }
 }
 
 #endif  // DART_PRECOMPILER
 
 }  // namespace dart