Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2896853002: Create SsaBuilderTask stub for KernelBackendStrategy (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -30 lines) Patch
M pkg/compiler/lib/src/backend_strategy.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 6 chunks +28 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 3 chunks +15 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +10 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-22 14:24:57 UTC) #2
Johnni Winther
PTAL
3 years, 7 months ago (2017-05-23 09:13:02 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-23 21:19:41 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-24 08:04:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b767ebaa717995c5cf57363ceb61d7dea756ac79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698