[DONT COMMIT] PaintWorklet: Move paintWorklet from 'window' to 'CSS'

PaintWorklet: Move paintWorklet from 'window' to 'CSS'

BUG=719303

[nhiroki, 2017-05-22 08:41:37]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 08:41:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 09:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 09:47:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-06-01 06:46:47]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 06:47:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 06:57:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 06:57:14]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nhiroki, 2017-06-01 13:18:00]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 13:18:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 14:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 14:31:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2017-06-12 08:15:52]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 08:16:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 10:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 10:30:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-06-13 08:22:54]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 08:23:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-06-13 08:41:02]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 08:41:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-06-13 08:50:30]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-06-13 08:50:38]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-06-13 08:50:46]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2017-06-13 08:51:49]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2017-06-13 08:51:58]

Patchset #1 (id:80001) has been deleted

[nhiroki, 2017-06-13 08:52:09]

Patchset #1 (id:100001) has been deleted

[nhiroki, 2017-06-13 08:52:17]

Patchset #1 (id:120001) has been deleted

[nhiroki, 2017-06-13 08:52:24]

Patchset #1 (id:140001) has been deleted

[nhiroki, 2017-06-13 08:52:31]

Patchset #1 (id:160001) has been deleted

[nhiroki, 2017-06-13 08:52:38]

Patchset #1 (id:180001) has been deleted

[nhiroki, 2017-06-13 08:56:57]

nhiroki@chromium.org changed reviewers:
+ yukishiino@chromium.org

[nhiroki, 2017-06-13 08:56:58]

+yukishiino@, I have a question. Can you see my review comment in
CSSPaintWorklet.cpp? Thanks.

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp (right):

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp:22: DLOG(ERROR)
<< document.Url().GetString();
yukishiino@: I have a question.

In LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html, this
log prints "import-on-detached-iframe.html" that is the main frame's URL. This
means "frame.contentWindow.CSS.paintWorklet" passes the main frame's ScriptState
to CSSPaintWorklet::paintWorklet(). Is this right behavior? I expect that
attribute access passes the iframe's ScriptState and this log prints the
iframe's URL "resources/blank.html".

[nhiroki, 2017-06-13 08:57:14]

Description was changed from

==========
PaintWorklet: Move paintWorklet from 'window' to 'CSS'

BUG=719303
==========

to

==========
PaintWorklet: Move paintWorklet from 'window' to 'CSS'

BUG=719303
==========

[nhiroki, 2017-06-13 09:41:56]

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp (right):

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp:22: DLOG(ERROR)
<< document.Url().GetString();
On 2017/06/13 08:56:58, nhiroki wrote:
> yukishiino@: I have a question.
> 
> In LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html,
this
> log prints "import-on-detached-iframe.html" that is the main frame's URL. This
> means "frame.contentWindow.CSS.paintWorklet" passes the main frame's
ScriptState
> to CSSPaintWorklet::paintWorklet(). Is this right behavior? I expect that
> attribute access passes the iframe's ScriptState and this log prints the
> iframe's URL "resources/blank.html".

Sample log:

[1:1:0613/021034.138374:3361121614:ERROR:CSSPaintWorklet.cpp(22)]
"http://127.0.0.1:8000/worklet/chromium/import-on-detached-iframe.html"

https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[nhiroki, 2017-06-13 10:13:38]

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp (right):

https://codereview.chromium.org/2896773002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.cpp:22: DLOG(ERROR)
<< document.Url().GetString();
On 2017/06/13 09:41:56, nhiroki wrote:
> On 2017/06/13 08:56:58, nhiroki wrote:
> > yukishiino@: I have a question.
> > 
> > In LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html,
> this
> > log prints "import-on-detached-iframe.html" that is the main frame's URL.
This
> > means "frame.contentWindow.CSS.paintWorklet" passes the main frame's
> ScriptState
> > to CSSPaintWorklet::paintWorklet(). Is this right behavior? I expect that
> > attribute access passes the iframe's ScriptState and this log prints the
> > iframe's URL "resources/blank.html".
> 
> Sample log:
> 
> [1:1:0613/021034.138374:3361121614:ERROR:CSSPaintWorklet.cpp(22)]
> "http://127.0.0.1:8000/worklet/chromium/import-on-detached-iframe.html"
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

According to yukishiino@, this could be a bug in V8...

See https://bugs.chromium.org/p/v8/issues/detail?id=6156

[commit-bot: I haz the power, 2017-06-13 10:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 10:49:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-08-24 07:17:17]

I re-uploaded the CL to Gerrit:
https://chromium-review.googlesource.com/c/chromium/src/+/630899