Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: headless/test/headless_browser_test.cc

Issue 2896763002: Implement window management devtools commands for headless. (Closed)
Patch Set: map 1 tab to 1 window and remove screen_size Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/test/headless_browser_test.cc
diff --git a/headless/test/headless_browser_test.cc b/headless/test/headless_browser_test.cc
index 1ad15d8077653c8302b77df83b336575ae76fb8b..114f1ed5191828d707242fd209b5a1f7f81d7fee 100644
--- a/headless/test/headless_browser_test.cc
+++ b/headless/test/headless_browser_test.cc
@@ -195,6 +195,7 @@ HeadlessAsyncDevTooledBrowserTest::HeadlessAsyncDevTooledBrowserTest()
: browser_context_(nullptr),
web_contents_(nullptr),
devtools_client_(HeadlessDevToolsClient::Create()),
+ browser_devtools_client_(HeadlessDevToolsClient::Create()),
render_process_exited_(false) {}
HeadlessAsyncDevTooledBrowserTest::~HeadlessAsyncDevTooledBrowserTest() {}
@@ -227,6 +228,7 @@ void HeadlessAsyncDevTooledBrowserTest::RunTest() {
browser_context_ = builder.Build();
browser()->SetDefaultBrowserContext(browser_context_);
+ browser()->GetDevToolsTarget()->AttachClient(browser_devtools_client_.get());
web_contents_ = browser_context_->CreateWebContentsBuilder()
.CreateTabSocket(GetCreateTabSocket())
@@ -240,6 +242,7 @@ void HeadlessAsyncDevTooledBrowserTest::RunTest() {
web_contents_->RemoveObserver(this);
web_contents_->Close();
web_contents_ = nullptr;
+ browser()->GetDevToolsTarget()->DetachClient(browser_devtools_client_.get());
browser_context_->Close();
browser_context_ = nullptr;
}
« headless/lib/browser/headless_web_contents_impl.h ('K') | « headless/test/headless_browser_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698