Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: chrome/browser/net/resource_prefetch_predictor_observer.h

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Move some logic into new class. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/resource_prefetch_predictor_observer.h
diff --git a/chrome/browser/net/resource_prefetch_predictor_observer.h b/chrome/browser/net/resource_prefetch_predictor_observer.h
index 4801540ce9be4e4b8c414fd8be20e694a61fae84..eed555a03cc3d63bd576664c13137320cc779021 100644
--- a/chrome/browser/net/resource_prefetch_predictor_observer.h
+++ b/chrome/browser/net/resource_prefetch_predictor_observer.h
@@ -9,7 +9,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "chrome/browser/predictors/resource_prefetch_predictor.h"
+#include "chrome/browser/predictors/loading_data_collector.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/common/resource_type.h"
@@ -31,7 +31,7 @@ namespace chrome_browser_net {
class ResourcePrefetchPredictorObserver {
Benoit L 2017/05/29 08:55:36 Can you change this name as well, since it no long
trevordixon 2017/06/02 12:10:36 Looks like you did it!
public:
explicit ResourcePrefetchPredictorObserver(
- predictors::ResourcePrefetchPredictor* predictor);
+ predictors::LoadingDataCollector* collector);
~ResourcePrefetchPredictorObserver();
// Parts of the ResourceDispatcherHostDelegate that we want to observe.
@@ -72,7 +72,7 @@ class ResourcePrefetchPredictorObserver {
const base::TimeTicks& creation_time) const;
// Owned by profile.
- base::WeakPtr<predictors::ResourcePrefetchPredictor> predictor_;
+ base::WeakPtr<predictors::LoadingDataCollector> collector_;
DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorObserver);
};

Powered by Google App Engine
This is Rietveld 408576698