Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2261)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc
index 3b9a1fda5dfad3a01c1b75def0ecb8f0fff82e58..015a06d76388ce056c0976bbd945a6ccee6c7c6d 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc
@@ -34,10 +34,9 @@ void ResourcePrefetchPredictorTabHelper::DocumentOnLoadCompletedInMainFrame() {
if (!loading_predictor)
return;
- auto* resource_prefetch_predictor =
- loading_predictor->resource_prefetch_predictor();
+ auto* collector = loading_predictor->loading_data_collector();
NavigationID navigation_id(web_contents());
- resource_prefetch_predictor->RecordMainFrameLoadComplete(navigation_id);
+ collector->RecordMainFrameLoadComplete(navigation_id);
}
void ResourcePrefetchPredictorTabHelper::DidLoadResourceFromMemoryCache(
@@ -59,9 +58,8 @@ void ResourcePrefetchPredictorTabHelper::DidLoadResourceFromMemoryCache(
ResourcePrefetchPredictor::GetResourceTypeFromMimeType(
mime_type, resource_type);
summary.was_cached = true;
- auto* resource_prefetch_predictor =
- loading_predictor->resource_prefetch_predictor();
- resource_prefetch_predictor->RecordURLResponse(summary);
+ auto* collector = loading_predictor->loading_data_collector();
+ collector->RecordURLResponse(summary);
}
} // namespace predictors

Powered by Google App Engine
This is Rietveld 408576698