Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
deleted file mode 100644
index 3278fbb7f959afd6b5f57016808fa3934e80367e..0000000000000000000000000000000000000000
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_
-#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_
-
-#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
-
-namespace content {
-class WebContents;
-}
-
-namespace predictors {
-class ResourcePrefetchPredictor;
-}
-
-namespace internal {
-
-extern const char kHistogramResourcePrefetchPredictorFirstContentfulPaint[];
-extern const char kHistogramResourcePrefetchPredictorFirstMeaningfulPaint[];
-
-} // namespace internal
-
-// Observer responsible for recording page load metrics relevant to
-// ResourcePrefetchPredictor.
-class ResourcePrefetchPredictorPageLoadMetricsObserver
- : public page_load_metrics::PageLoadMetricsObserver {
- public:
- // Returns a ResourcePrefetchPredictorPageLoadMetricsObserver, or nullptr if
- // it is not needed.
- static std::unique_ptr<ResourcePrefetchPredictorPageLoadMetricsObserver>
- CreateIfNeeded(content::WebContents* web_contents);
-
- // Public for testing. Normally one should use CreateIfNeeded. Predictor must
- // outlive this observer.
- explicit ResourcePrefetchPredictorPageLoadMetricsObserver(
- predictors::ResourcePrefetchPredictor* predictor,
- content::WebContents* web_contents);
-
- ~ResourcePrefetchPredictorPageLoadMetricsObserver() override;
-
- // page_load_metrics::PageLoadMetricsObserver:
- ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
- const GURL& currently_commited_url,
- bool started_in_foreground) override;
- ObservePolicy OnHidden(
- const page_load_metrics::mojom::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstContentfulPaintInPage(
- const page_load_metrics::mojom::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstMeaningfulPaintInMainFrameDocument(
- const page_load_metrics::mojom::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) override;
-
- private:
- predictors::ResourcePrefetchPredictor* predictor_;
- content::WebContents* web_contents_;
- bool record_histograms_;
-
- DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorPageLoadMetricsObserver);
-};
-
-#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698