Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Rebase, merge loading_stats_collector. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
index faa430279c52fb484ed14835d2e6513849173696..a138b85ee8ba8fe1db3d707e2aae325f770cbb38 100644
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
@@ -34,17 +34,21 @@ ResourcePrefetchPredictorPageLoadMetricsObserver::CreateIfNeeded(
if (!loading_predictor)
return nullptr;
return base::MakeUnique<ResourcePrefetchPredictorPageLoadMetricsObserver>(
- loading_predictor->resource_prefetch_predictor(), web_contents);
+ loading_predictor->resource_prefetch_predictor(),
+ loading_predictor->loading_data_collector(), web_contents);
}
ResourcePrefetchPredictorPageLoadMetricsObserver::
ResourcePrefetchPredictorPageLoadMetricsObserver(
predictors::ResourcePrefetchPredictor* predictor,
+ predictors::LoadingDataCollector* collector,
content::WebContents* web_contents)
: predictor_(predictor),
+ collector_(collector),
web_contents_(web_contents),
record_histograms_(false) {
DCHECK(predictor_);
+ DCHECK(collector_);
}
ResourcePrefetchPredictorPageLoadMetricsObserver::
@@ -76,7 +80,7 @@ void ResourcePrefetchPredictorPageLoadMetricsObserver::
const page_load_metrics::PageLoadExtraInfo& extra_info) {
predictors::NavigationID navigation_id(web_contents_);
- predictor_->RecordFirstContentfulPaint(
+ collector_->RecordFirstContentfulPaint(
navigation_id, extra_info.navigation_start +
timing.paint_timing->first_contentful_paint.value());
if (record_histograms_) {

Powered by Google App Engine
This is Rietveld 408576698