chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h - Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)

Patch Set: Reset MockURLRequestJobFactory Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/loading_predictor_observer.cc ('k') | chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc » ('j') | chrome/browser/predictors/loading_data_collector_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

index 3278fbb7f959afd6b5f57016808fa3934e80367e..d29d9c1b6d8a64944d440dd10c6af23cabba2509 100644

--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_

#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_

+#include <memory>

#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"

namespace content {

@@ -13,6 +14,7 @@ class WebContents;

namespace predictors {

class ResourcePrefetchPredictor;

+class LoadingDataCollector;

}

namespace internal {

@@ -36,6 +38,7 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver

// outlive this observer.

explicit ResourcePrefetchPredictorPageLoadMetricsObserver(

predictors::ResourcePrefetchPredictor* predictor,

+ predictors::LoadingDataCollector* collector,

content::WebContents* web_contents);

~ResourcePrefetchPredictorPageLoadMetricsObserver() override;

@@ -56,6 +59,7 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver

private:

predictors::ResourcePrefetchPredictor* predictor_;

+ predictors::LoadingDataCollector* collector_;

content::WebContents* web_contents_;

bool record_histograms_;