chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc - Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)

Patch Set: Address lizeb feedback. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/predictors/loading_data_collector_unittest.cc ('K') | « chrome/browser/predictors/resource_prefetch_predictor.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

diff --git a/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc b/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

index 03bd3d3fad24870cfad760a8bff170b62402a5b1..efecae09e71f9c2b396b5caf1b0ca874fe07d61d 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

+++ b/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

@@ -13,9 +13,10 @@

#include "base/test/histogram_tester.h"

#include "chrome/browser/browsing_data/browsing_data_helper.h"

+#include "chrome/browser/predictors/loading_data_collector.h"

#include "chrome/browser/predictors/loading_predictor.h"

#include "chrome/browser/predictors/loading_predictor_factory.h"

-#include "chrome/browser/predictors/resource_prefetch_predictor_test_util.h"

+#include "chrome/browser/predictors/loading_test_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -368,13 +369,13 @@ class ResourcePrefetchPredictorBrowserTest : public InProcessBrowserTest {

ASSERT_TRUE(predictor_);

resource_prefetch_predictor_ = predictor_->resource_prefetch_predictor();

// URLs from the test server contain a port number.

- ResourcePrefetchPredictor::SetAllowPortInUrlsForTesting(true);

+ LoadingDataCollector::SetAllowPortInUrlsForTesting(true);

EnsurePredictorInitialized();

histogram_tester_.reset(new base::HistogramTester());

}

void TearDownOnMainThread() override {

- ResourcePrefetchPredictor::SetAllowPortInUrlsForTesting(false);

+ LoadingDataCollector::SetAllowPortInUrlsForTesting(false);

}

void TestLearningAndPrefetching(