Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Address lizeb feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
index 3278fbb7f959afd6b5f57016808fa3934e80367e..d29d9c1b6d8a64944d440dd10c6af23cabba2509 100644
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_
+#include <memory>
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
namespace content {
@@ -13,6 +14,7 @@ class WebContents;
namespace predictors {
class ResourcePrefetchPredictor;
+class LoadingDataCollector;
}
namespace internal {
@@ -36,6 +38,7 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver
// outlive this observer.
explicit ResourcePrefetchPredictorPageLoadMetricsObserver(
predictors::ResourcePrefetchPredictor* predictor,
+ predictors::LoadingDataCollector* collector,
content::WebContents* web_contents);
~ResourcePrefetchPredictorPageLoadMetricsObserver() override;
@@ -56,6 +59,7 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver
private:
predictors::ResourcePrefetchPredictor* predictor_;
+ predictors::LoadingDataCollector* collector_;
content::WebContents* web_contents_;
bool record_histograms_;

Powered by Google App Engine
This is Rietveld 408576698