Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor

chrome/browser/predictors/resource_prefetch_predictor_test_util.h

Index: chrome/browser/predictors/resource_prefetch_predictor_test_util.h
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_test_util.h b/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
index d11f783fd39bacd28fc88066f5cf6ae4f6c70e0d..706ee4c5c771e9036c6a69a9769448354b010698 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
+++ b/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
@@ -10,6 +10,9 @@
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor_tables.h"
 #include "components/sessions/core/session_id.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_job.h"
+#include "net/url_request/url_request_job_factory.h"
 
 namespace predictors {
 
@@ -79,6 +82,58 @@ ResourcePrefetchPredictor::URLRequestSummary CreateURLRequestSummary(
 
 void PopulateTestConfig(LoadingPredictorConfig* config, bool small_db = true);
 
+scoped_refptr<net::HttpResponseHeaders> MakeResponseHeaders(
+    const char* headers);
+
+class MockURLRequestJob : public net::URLRequestJob {
+ public:
+  MockURLRequestJob(net::URLRequest* request,
+                    const net::HttpResponseInfo& response_info,
+                    const std::string& mime_type);
+
+  bool GetMimeType(std::string* mime_type) const override;
+
+ protected:
+  void Start() override;
+  void GetResponseInfo(net::HttpResponseInfo* info) override;
+
+ private:
+  net::HttpResponseInfo response_info_;
+  std::string mime_type_;
+};
+
+class MockURLRequestJobFactory : public net::URLRequestJobFactory {
+ public:
+  MockURLRequestJobFactory();
+  ~MockURLRequestJobFactory() override;
+
+  net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
+      const std::string& scheme,
+      net::URLRequest* request,
+      net::NetworkDelegate* network_delegate) const override;
+
+  net::URLRequestJob* MaybeInterceptRedirect(
+      net::URLRequest* request,
+      net::NetworkDelegate* network_delegate,
+      const GURL& location) const override;
+
+  net::URLRequestJob* MaybeInterceptResponse(
+      net::URLRequest* request,
+      net::NetworkDelegate* network_delegate) const override;
+
+  bool IsHandledProtocol(const std::string& scheme) const override;
+
+  bool IsSafeRedirectTarget(const GURL& location) const override;
+
+  void set_response_info(const net::HttpResponseInfo& response_info);

[Benoit L, 2017/06/02 12:44:00]

nit: you can inline trivial setters.

[trevordixon, 2017/06/06 13:08:04]

Done.

+
+  void set_mime_type(const std::string& mime_type);
+
+ private:
+  net::HttpResponseInfo response_info_;
+  std::string mime_type_;
+};
+
 // For printing failures nicely.
 std::ostream& operator<<(std::ostream& stream, const PrefetchData& data);
 std::ostream& operator<<(std::ostream& stream, const ResourceData& resource);