Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2896713003: Create LoadingDataCollector class and have observers rely on it instead of ResourcePrefetchPredictor (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"
6 6
7 #include <memory>
8 #include <utility>
9
7 #include "base/macros.h" 10 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
9 #include "base/timer/timer.h" 12 #include "base/timer/timer.h"
10 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 13 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
11 #if defined(OS_ANDROID) 14 #if defined(OS_ANDROID)
12 #include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_o bserver.h" 15 #include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_o bserver.h"
13 #endif // OS_ANDROID 16 #endif // OS_ANDROID
14 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 17 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
15 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_obser ver.h" 18 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_obser ver.h"
16 #include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_obser ver.h" 19 #include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_obser ver.h"
17 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 20 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
18 #include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metr ics_observer.h" 21 #include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metr ics_observer.h"
19 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metric s_observer.h" 22 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metric s_observer.h"
20 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h" 23 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h"
21 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 24 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
22 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h" 25 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h"
23 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h" 26 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
24 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h" 27 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h"
28 #include "chrome/browser/page_load_metrics/observers/loading_predictor_page_load _metrics_observer.h"
25 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h" 29 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h"
26 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h" 30 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h"
27 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h" 31 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
28 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h" 32 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h"
29 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h" 33 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h"
30 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h" 34 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h"
31 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h" 35 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h"
32 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h"
33 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h" 36 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h"
34 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h" 37 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h"
35 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h" 38 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h"
36 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h" 39 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h"
37 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h" 40 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h"
38 #include "chrome/browser/page_load_metrics/page_load_tracker.h" 41 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
39 #include "chrome/browser/prerender/prerender_contents.h" 42 #include "chrome/browser/prerender/prerender_contents.h"
40 #include "chrome/browser/profiles/profile.h" 43 #include "chrome/browser/profiles/profile.h"
41 #include "chrome/browser/search/search.h" 44 #include "chrome/browser/search/search.h"
42 #include "components/rappor/rappor_service_impl.h" 45 #include "components/rappor/rappor_service_impl.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 no_state_prefetch_observer = 117 no_state_prefetch_observer =
115 NoStatePrefetchPageLoadMetricsObserver::CreateIfNeeded( 118 NoStatePrefetchPageLoadMetricsObserver::CreateIfNeeded(
116 web_contents_); 119 web_contents_);
117 if (no_state_prefetch_observer) 120 if (no_state_prefetch_observer)
118 tracker->AddObserver(std::move(no_state_prefetch_observer)); 121 tracker->AddObserver(std::move(no_state_prefetch_observer));
119 #if defined(OS_ANDROID) 122 #if defined(OS_ANDROID)
120 tracker->AddObserver( 123 tracker->AddObserver(
121 base::MakeUnique<AndroidPageLoadMetricsObserver>(web_contents_)); 124 base::MakeUnique<AndroidPageLoadMetricsObserver>(web_contents_));
122 #endif // OS_ANDROID 125 #endif // OS_ANDROID
123 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> 126 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
124 resource_prefetch_predictor_observer = 127 loading_predictor_observer =
125 ResourcePrefetchPredictorPageLoadMetricsObserver::CreateIfNeeded( 128 LoadingPredictorPageLoadMetricsObserver::CreateIfNeeded(
126 web_contents_); 129 web_contents_);
127 if (resource_prefetch_predictor_observer) 130 if (loading_predictor_observer)
128 tracker->AddObserver(std::move(resource_prefetch_predictor_observer)); 131 tracker->AddObserver(std::move(loading_predictor_observer));
129 } else { 132 } else {
130 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> 133 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
131 prerender_observer = 134 prerender_observer =
132 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_); 135 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_);
133 if (prerender_observer) 136 if (prerender_observer)
134 tracker->AddObserver(std::move(prerender_observer)); 137 tracker->AddObserver(std::move(prerender_observer));
135 } 138 }
136 tracker->AddObserver( 139 tracker->AddObserver(
137 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering())); 140 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering()));
138 tracker->AddObserver( 141 tracker->AddObserver(
(...skipping 21 matching lines...) Expand all
160 163
161 void InitializePageLoadMetricsForWebContents( 164 void InitializePageLoadMetricsForWebContents(
162 content::WebContents* web_contents, 165 content::WebContents* web_contents,
163 const base::Optional<content::WebContents::CreateParams>& create_params) { 166 const base::Optional<content::WebContents::CreateParams>& create_params) {
164 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents( 167 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
165 web_contents, create_params, 168 web_contents, create_params,
166 base::MakeUnique<PageLoadMetricsEmbedder>(web_contents)); 169 base::MakeUnique<PageLoadMetricsEmbedder>(web_contents));
167 } 170 }
168 171
169 } // namespace chrome 172 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698