Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

Issue 2896703003: [DMC #11] Move some rendered rect method impls from DMC To TextMatchMarkerListImpl (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
index ca4ae45f27b214b1bd72e2f1adf01ea3ae27bd8a..e46655de354a23e53219bd0606adcdca4288cf58 100644
--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
@@ -9,6 +9,9 @@
namespace blink {
+class IntRect;
+class RenderedDocumentMarker;
+
// Implementation of DocumentMarkerList for TextMatch markers.
// Markers are kept sorted by start offset, under the assumption that
// TextMatch markers are typically inserted in an order.
@@ -33,6 +36,10 @@ class CORE_EXPORT TextMatchMarkerListImpl final : public DocumentMarkerList {
unsigned new_length) final;
DECLARE_VIRTUAL_TRACE();
+ // TextMatchMarkerListImpl-specific
+ void AppendRenderedRectsToVector(const Node&, Vector<IntRect>*);
yosin_UTC9 2017/05/22 05:24:18 Let's make this function to return |Vector<IntRect
+ void UpdateMarkerRenderedRectIfNeeded(const Node&, RenderedDocumentMarker&);
yosin_UTC9 2017/05/22 05:24:18 nit: |UpdateMarkerRenderedRectIfNeeded()| should b
+
private:
HeapVector<Member<DocumentMarker>> markers_;

Powered by Google App Engine
This is Rietveld 408576698