third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc - Issue 2896603002: [scheduler] Move task alignment into WakeUpBudgetPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

Issue 2896603002: [scheduler] Move task alignment into WakeUpBudgetPool. (Closed)

Patch Set: no iostream Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h » ('j') | third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

index d31d49cb48dc22328bb506ae3bbd3456b6dc139a..b80dc892225328928b3fc4fdd3dd7235fa5c78e2 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

@@ -157,7 +157,7 @@ TEST_F(BudgetPoolTest, WakeUpBudgetPool) {

// GetNextAllowedRunTime should return the desired time when in the

// wakeup window and return the next wakeup otherwise.

EXPECT_EQ(start_time_, pool->GetNextAllowedRunTime(start_time_));

- EXPECT_EQ(SecondsAfterStart(10) - base::TimeDelta::FromMicroseconds(1),

+ EXPECT_EQ(base::TimeTicks() + base::TimeDelta::FromSeconds(10),

pool->GetNextAllowedRunTime(MillisecondsAfterStart(15)));

pool->RecordTaskRunTime(queue.get(), MillisecondsAfterStart(5),

@@ -170,7 +170,7 @@ TEST_F(BudgetPoolTest, WakeUpBudgetPool) {

EXPECT_FALSE(pool->CanRunTasksAt(MillisecondsAfterStart(10), false));

EXPECT_FALSE(pool->CanRunTasksAt(MillisecondsAfterStart(11), false));

EXPECT_EQ(start_time_, pool->GetNextAllowedRunTime(start_time_));

- EXPECT_EQ(SecondsAfterStart(10) - base::TimeDelta::FromMicroseconds(1),

+ EXPECT_EQ(base::TimeTicks() + base::TimeDelta::FromSeconds(10),

pool->GetNextAllowedRunTime(MillisecondsAfterStart(15)));

pool->OnWakeUp(MillisecondsAfterStart(12005));

@@ -182,9 +182,8 @@ TEST_F(BudgetPoolTest, WakeUpBudgetPool) {

EXPECT_TRUE(pool->CanRunTasksAt(MillisecondsAfterStart(12014), false));

EXPECT_FALSE(pool->CanRunTasksAt(MillisecondsAfterStart(12015), false));

EXPECT_FALSE(pool->CanRunTasksAt(MillisecondsAfterStart(12016), false));

- EXPECT_EQ(

- MillisecondsAfterStart(22005) - base::TimeDelta::FromMicroseconds(1),

- pool->GetNextAllowedRunTime(SecondsAfterStart(13)));

+ EXPECT_EQ(base::TimeTicks() + base::TimeDelta::FromSeconds(20),

+ pool->GetNextAllowedRunTime(SecondsAfterStart(13)));

}

} // namespace scheduler