device/generic_sensor/platform_sensor_provider_android.cc - Issue 2896583005: Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/generic_sensor/platform_sensor_provider_android.cc

Issue 2896583005: Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (Closed)

Patch Set: fix issues on Android, Mac and Windows Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/generic_sensor/platform_sensor_provider_android.cc

diff --git a/device/generic_sensor/platform_sensor_provider_android.cc b/device/generic_sensor/platform_sensor_provider_android.cc

index 05a008a2cfb3982b1f2026e0cbb1cf9c5db4623e..c9abbdf322f4d6cef106fb5db19f02705981acad 100644

--- a/device/generic_sensor/platform_sensor_provider_android.cc

+++ b/device/generic_sensor/platform_sensor_provider_android.cc

@@ -36,8 +36,10 @@ void PlatformSensorProviderAndroid::CreateSensorInternal(

ScopedJavaLocalRef<jobject> sensor = Java_PlatformSensorProvider_createSensor(

env, j_object_.obj(), static_cast<jint>(type));

- if (!sensor.obj())

+ if (!sensor.obj()) {

callback.Run(nullptr);

+ return;

+ }

scoped_refptr<PlatformSensorAndroid> concrete_sensor =

new PlatformSensorAndroid(type, std::move(mapping), this, sensor);