Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/test/data/device_sensors/device_motion_test.html

Issue 2896583005: Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (Closed)
Patch Set: address more comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/device_sensors/device_motion_event_pump.cc ('K') | « content/test/data/device_sensors/device_motion_only_some_sensors_are_available_test.html ('k') | device/generic_sensor/BUILD.gn » ('j') | device/generic_sensor/sensor_provider_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/data/device_sensors/device_motion_test.html
diff --git a/content/test/data/device_sensors/device_motion_test.html b/content/test/data/device_sensors/device_motion_test.html
index 11b4e05df1bb0d9832a7ba1a36df38ebc0527a58..c1aa8c9a2f92d4539a86c957dfa900366f05f94d 100644
--- a/content/test/data/device_sensors/device_motion_test.html
+++ b/content/test/data/device_sensors/device_motion_test.html
@@ -2,6 +2,7 @@
<head>
<title>DeviceMotion test</title>
<script type="text/javascript">
+ let expectedInterval = Math.floor(1000000 / 60);
timvolodine 2017/06/07 20:37:36 is this in microseconds? the device orientation sp
juncai 2017/06/07 23:05:08 Yes, it should be in milliseconds. Thanks! Done.
function checkMotionEvent(event) {
return event.acceleration.x == 1 &&
event.acceleration.y == 2 &&
@@ -12,7 +13,7 @@
event.rotationRate.alpha == 7 &&
event.rotationRate.beta == 8 &&
event.rotationRate.gamma == 9 &&
- event.interval == 100;
+ event.interval == expectedInterval;
}
function onMotion(event) {
« content/renderer/device_sensors/device_motion_event_pump.cc ('K') | « content/test/data/device_sensors/device_motion_only_some_sensors_are_available_test.html ('k') | device/generic_sensor/BUILD.gn » ('j') | device/generic_sensor/sensor_provider_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698