device/generic_sensor/public/interfaces/BUILD.gn - Issue 2896583005: Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/generic_sensor/public/interfaces/BUILD.gn

Issue 2896583005: Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (Closed)

Patch Set: updated test code Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/device_sensors/device_motion_event_pump_unittest.cc ('K') | « content/test/layouttest_support.cc ('k') | services/device/device_service.h » ('j') | third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionData.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//mojo/public/tools/bindings/mojom.gni")	5 import("//mojo/public/tools/bindings/mojom.gni")

6	6

7 mojom("interfaces") {	7 mojom("interfaces") {

8 visibility = [ "//device/generic_sensor/public/cpp" ]
Reilly Grant (use Gerrit) 2017/05/22 20:29:46 The way device/generic_sensor/public/cpp/BUILD.gn The way device/generic_sensor/public/cpp/BUILD.gn is set up you should be able to depend on device/generic_sensor/public/cpp anywhere where you want to depend on device/generic_sensor/public/interfaces. juncai 2017/05/23 02:30:24 Done. Show quoted text On 2017/05/22 20:29:46, Reilly Grant wrote: > The way device/generic_sensor/public/cpp/BUILD.gn is set up you should be able > to depend on device/generic_sensor/public/cpp anywhere where you want to depend > on device/generic_sensor/public/interfaces. Done.
9 visibility_blink = [ "//third_party/WebKit/Source/*" ]	8 visibility_blink = [ "//third_party/WebKit/Source/*" ]

10 component_output_prefix = "generic_sensor_public_interfaces"	9 component_output_prefix = "generic_sensor_public_interfaces"

11 export_class_attribute = "DEVICE_GENERIC_SENSOR_PUBLIC_EXPORT"	10 export_class_attribute = "DEVICE_GENERIC_SENSOR_PUBLIC_EXPORT"

12 export_define = "DEVICE_GENERIC_SENSOR_PUBLIC_IMPLEMENTATION=1"	11 export_define = "DEVICE_GENERIC_SENSOR_PUBLIC_IMPLEMENTATION=1"

13 export_header =	12 export_header =

14 "device/generic_sensor/public/cpp/generic_sensor_public_export.h"	13 "device/generic_sensor/public/cpp/generic_sensor_public_export.h"

15 sources = [	14 sources = [

16 "sensor.mojom",	15 "sensor.mojom",

17 "sensor_provider.mojom",	16 "sensor_provider.mojom",

18 ]	17 ]

19	18

20 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.	19 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.

21 use_once_callback = false	20 use_once_callback = false

22 }	21 }

OLD	NEW