Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors

content/browser/device_sensors/device_sensor_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
@@ skipping 297 matching lines @@
   // handler and navigates to #pass.
   GURL test_url =
       GetTestUrl("device_sensors", "device_orientation_absolute_test.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
 
   EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
   orientation_absolute_started_runloop_->Run();
   orientation_absolute_stopped_runloop_->Run();
 }
 
-IN_PROC_BROWSER_TEST_F(DeviceSensorBrowserTest, MotionTest) {

[Reilly Grant (use Gerrit), 2017/05/22 20:29:46]

Where did these tests move to?

[juncai, 2017/05/23 02:30:23]

Talked to reillyg@ offline, these tests are already covered by device motion
event pump unit tests and device motion event layout tests. 

[timvolodine, 2017/05/23 12:33:40]

what is the reason for removing this? strictly speaking the browser tests are
end-to-end and are not the same as unit tests / layout tests..

[juncai, 2017/05/23 21:33:55]

I think the layout tests at:
//third_party/WebKit/LayoutTests/device_orientation/motion
covers the browser tests here. For example,
//third_party/WebKit/LayoutTests/device_orientation/motion/null-values.html
is similar to the DeviceSensorBrowserTest's MotionNullTest.

And the device motion event unit tests are updated to cover cases when different
sensors are available and make sure the sensor data sent to the blink side is
correct:
https://codereview.chromium.org/2896583005/diff/60001/content/renderer/device...

[timvolodine, 2017/05/24 15:30:15]

The //third_party/WebKit/LayoutTests/device_orientation/motion uses testRunner,
which sets the mock values and the test does not go beyond blink platform, i.e.
it's not the same as the browsertests.

Can we just keep the existing browser test here? or are there issues because the
implementation switches over to a different 'back-end'?

[juncai, 2017/05/26 02:38:52]

Thanks for the comments. I updated device sensors browsertest.

Done.

-  // The test page will register an event handler for motion events,
-  // expects to get an event with fake values, then removes the event
-  // handler and navigates to #pass.
-  GURL test_url = GetTestUrl("device_sensors", "device_motion_test.html");
-  NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
-
-  EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
-  motion_started_runloop_->Run();
-  motion_stopped_runloop_->Run();
-}
-
 IN_PROC_BROWSER_TEST_F(DeviceSensorBrowserTest, OrientationNullTest) {
   // The test page registers an event handler for orientation events and
   // expects to get an event with null values, because no sensor data can be
   // provided.
   fetcher_->SetSensorDataAvailable(false);
   GURL test_url =
       GetTestUrl("device_sensors", "device_orientation_null_test.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
 
   EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
   orientation_started_runloop_->Run();
   orientation_stopped_runloop_->Run();
 }
 
 IN_PROC_BROWSER_TEST_F(DeviceSensorBrowserTest, OrientationAbsoluteNullTest) {
   // The test page registers an event handler for absolute orientation events
   // and expects to get an event with null values, because no sensor data can be
   // provided.
   fetcher_->SetSensorDataAvailable(false);
   GURL test_url = GetTestUrl("device_sensors",
                              "device_orientation_absolute_null_test.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
 
   EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
   orientation_absolute_started_runloop_->Run();
   orientation_absolute_stopped_runloop_->Run();
 }
 
-IN_PROC_BROWSER_TEST_F(DeviceSensorBrowserTest, MotionNullTest) {
-  // The test page registers an event handler for motion events and
-  // expects to get an event with null values, because no sensor data can be
-  // provided.
-  fetcher_->SetSensorDataAvailable(false);
-  GURL test_url = GetTestUrl("device_sensors", "device_motion_null_test.html");
-  NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
-
-  EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
-  motion_started_runloop_->Run();
-  motion_stopped_runloop_->Run();
-}
-
 IN_PROC_BROWSER_TEST_F(DeviceSensorBrowserTest, NullTestWithAlert) {
   // The test page registers an event handlers for motion/orientation events and
   // expects to get events with null values. The test raises a modal alert
   // dialog with a delay to test that the one-off null-events still propagate to
   // window after the alert is dismissed and the callbacks are invoked which
   // eventually navigate to #pass.
   fetcher_->SetSensorDataAvailable(false);
   TestNavigationObserver same_tab_observer(shell()->web_contents(), 2);
 
   GURL test_url =
       GetTestUrl("device_sensors", "device_sensors_null_test_with_alert.html");
   shell()->LoadURL(test_url);
 
   // TODO(timvolodine): investigate if it is possible to test this without
   // delay, crbug.com/360044.
   WaitForAlertDialogAndQuitAfterDelay(base::TimeDelta::FromMilliseconds(500));
 
-  motion_started_runloop_->Run();
-  motion_stopped_runloop_->Run();
   orientation_started_runloop_->Run();
   orientation_stopped_runloop_->Run();
   same_tab_observer.Wait();
   EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
 }
 
 }  //  namespace
 
 }  //  namespace content