Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2896583002: Fix flaky test that makes assumptions about other things on the heap (Closed)

Created:
3 years, 7 months ago by erikcorry
Modified:
3 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix flaky test that makes assumptions about other things on the heap R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bd6f0800fc755ec118a31f82b4dadbdfd6671255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M runtime/observatory/tests/service/object_graph_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 7 months ago (2017-05-19 14:21:18 UTC) #1
Bill Hesse
LGTM
3 years, 7 months ago (2017-05-19 14:33:39 UTC) #2
erikcorry
3 years, 7 months ago (2017-05-19 14:59:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd6f0800fc755ec118a31f82b4dadbdfd6671255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698