Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2896553003: Re-enable GPU-GPU copies of video textures to GL_RED (Closed)
Patch Set: rebased and clean up Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/skcanvas_video_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
index a1a75aa6679f37655eb1e904e85f14a3f1ebc121..8d5f225046d7ef03b72f800c25b7dd3b8cab5184 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -4878,13 +4878,6 @@ bool WebGLRenderingContextBase::CanUseTexImageByGPU(GLenum format,
if (type == GL_UNSIGNED_SHORT_5_5_5_1)
return false;
#endif
- // TODO(kbr): bugs were observed when using CopyTextureCHROMIUM to
- // copy hardware-accelerated video textures to red-channel textures.
- // These bugs were seen on macOS but may indicate more general
- // problems. Investigate the root cause of this and fix it.
- // crbug.com/710673
- if (format == GL_RED || format == GL_RED_INTEGER)
- return false;
#if defined(OS_ANDROID)
// TODO(kbr): bugs were seen on Android devices with NVIDIA GPUs
« no previous file with comments | « media/renderers/skcanvas_video_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698