Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4982)

Unified Diff: chrome/browser/resources/print_preview/search/destination_list.js

Issue 2896463004: Print Preview: Mac: Do not blur focused item while opening the hamburger menu. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/search/destination_list.js
diff --git a/chrome/browser/resources/print_preview/search/destination_list.js b/chrome/browser/resources/print_preview/search/destination_list.js
index 9b9647a00bf39eb3414b75b50c2300473f3cf6c5..d92cc07bedefb6b4479245f91a79d6b702621c8a 100644
--- a/chrome/browser/resources/print_preview/search/destination_list.js
+++ b/chrome/browser/resources/print_preview/search/destination_list.js
@@ -336,7 +336,8 @@ cr.define('print_preview', function() {
if (focusedEl)
itemEl.classList.add('moving');
// Move it to the end of the list.
- listEl.appendChild(itemEl);
+ if (listEl.lastChild != itemEl)
dpapad 2017/05/23 01:02:06 Without a regression test, and without any comment
tkent 2017/05/23 03:54:53 I found why :focus didn't work, and Patch Set 2 re
+ listEl.appendChild(itemEl);
// Restore focus.
if (focusedEl) {
if (focusedEl == itemEl || focusedEl == focusedInnerEl)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698