Print Preview: Mac: Do not blur focused item while opening the hamburger menu.

chrome/browser/resources/print_preview/search/destination_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Component that displays a list of destinations with a heading, action link,
    * and "Show All..." button. An event is dispatched when the action link is
@@ skipping 288 matching lines @@
         visibleListItems[destinations[i].id] = null;
       // Update visibility for all existing list items.
       this.listItems_.forEach(function(item) {
         var isVisible = visibleListItems.hasOwnProperty(item.destination.id);
         setIsVisible(item.getElement(), isVisible);
         if (isVisible)
           visibleListItems[item.destination.id] = item;
       });
       // Update the existing items, add the new ones (preserve the focused one).
       var listEl = this.getChildElement('.destination-list > ul');
-      var focusedEl = listEl.querySelector(':focus');
+      // We need to use activeElement instead of :focus selector, which doesn't
+      // work in an inactive page. See crbug.com/723579.

[dpapad, 2017/05/23 18:57:30]

Out of curiosity, does crbug.com/723579 happen for the new :focus-within pseudo
selector too?

[tkent, 2017/05/24 01:37:17]

:focus-within means just "contains a :focus element."  So, :focus-within won't
fix crbug.com/723579.

+      var focusedEl = listEl.contains(document.activeElement) ?
+          document.activeElement : null;
       for (var i = 0; i < numItems; i++) {
         var destination = assert(destinations[i]);
         var listItem = visibleListItems[destination.id];
         if (listItem) {
           // Destination ID is the same, but it can be registered to a different
           // user account, hence passing it to the item update.
           this.updateListItem_(listEl, listItem, focusedEl, destination);
         } else {
           this.renderListItem_(listEl, destination);
         }
       }
     },
 
     /**
      * @param {Element} listEl List element.
      * @param {!print_preview.DestinationListItem} listItem List item to update.
      * @param {Element} focusedEl Currently focused element within the listEl.
      * @param {!print_preview.Destination} destination Destination to render.
      * @private
      */
     updateListItem_: function(listEl, listItem, focusedEl, destination) {
       listItem.update(destination, this.query_);
 
       var itemEl = listItem.getElement();
       // Preserve focused inner element, if there's one.
-      var focusedInnerEl = focusedEl ? itemEl.querySelector(':focus') : null;
+      var focusedInnerEl = focusedEl && itemEl.contains(focusedEl) ?
+          focusedEl : null;
       if (focusedEl)
         itemEl.classList.add('moving');
       // Move it to the end of the list.
-      listEl.appendChild(itemEl);
+      if (listEl.lastChild != itemEl)

[dpapad, 2017/05/23 18:57:30]

Did you mean to remove this in patch#2?

[tkent, 2017/05/24 01:37:17]

Oops.  Removed.

+        listEl.appendChild(itemEl);
       // Restore focus.
       if (focusedEl) {
         if (focusedEl == itemEl || focusedEl == focusedInnerEl)
           focusedEl.focus();
         itemEl.classList.remove('moving');
       }
     },
 
     /**
      * @param {Element} listEl List element.
@@ skipping 17 matching lines @@
       cr.dispatchSimpleEvent(this,
                              DestinationList.EventType.ACTION_LINK_ACTIVATED);
     }
   };
 
   // Export
   return {
     DestinationList: DestinationList
   };
 });